DM-27147: consolidate skymap definitions in Gen3 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now always write skymaps to the same dataset type and collection, so those are no longer useful arguments. And we write the dataset as well as adding the dimensions in BaseSkyMap.register now, so there's less for these to do. This also fixes the handling of config.doAppend in MakeDiscreteSkyMap, which can't have worked properly before because you're just not allowed to update a skymap in place without changing its name. The user is now required to supply an old name that must differ from the new name when appending. The makeGen3SkyMap.py script here really should be converted to a butler subcommand, but I don't want any more scope on this ticket. It doesn't really need to be backed by a Task, either, given how simple it is, but that might make it a bit easier to get the right defualt configuration from obs packages, which is fairly important.
TallJimbo
force-pushed
the
tickets/DM-27147
branch
from
08c36d7
to
b3774f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.