Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-27147: consolidate skymap definitions in Gen3 #431

Merged
merged 2 commits into from
Nov 26, 2020
Merged

DM-27147: consolidate skymap definitions in Gen3 #431

merged 2 commits into from
Nov 26, 2020

Commits on Nov 25, 2020

  1. Simplify Gen3 skymap creation tasks. 

    We now always write skymaps to the same dataset type and collection,
so those are no longer useful arguments.  And we write the dataset
as well as adding the dimensions in BaseSkyMap.register now, so there's
less for these to do.

This also fixes the handling of config.doAppend in MakeDiscreteSkyMap,
which can't have worked properly before because you're just not allowed
to update a skymap in place without changing its name.  The user is
now required to supply an old name that must differ from the new name
when appending.

The makeGen3SkyMap.py script here really should be converted to a
butler subcommand, but I don't want any more scope on this ticket.
It doesn't really need to be backed by a Task, either, given how
simple it is, but that might make it a bit easier to get the right
defualt configuration from obs packages, which is fairly important.
    @TallJimbo
    TallJimbo committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    d18f8cb View commit details
    Browse the repository at this point in the history

  2. Switch to a single, standard dataset type name for all skymap inputs.

    @TallJimbo
    TallJimbo committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    b3774f1 View commit details
    Browse the repository at this point in the history