Fix a bug in how aperture correction is applied #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-6063
branch
2 times, most recently
from
0fb7cf8
to
0bc844a
Compare
With the current flow, the aperture corrections were being applied only after all the measurement plugins had run through, independent of their execution order. This resulted in plugins whose measurements rely on aperture corrected fluxes (i.e. with execution order > APCORR_ORDER) being applied prior to the aperture correction, leading to erroneous results. The only plugin currently affected by this is base_ClassificationExtendedness. We handle this here by running the measurement and aperture correction in DetectAndMeasure in three stages: first run all plugins up to order APCORR_ORDER to measure all fluxes; second run a step whose only action is to apply the aperture corrections to the fluxes measured in the first step; finally, run all remaining (APCORR_ORDER+1) plugins, whose measurements rely on aperture-corrected fluxes, but with aperture correction disabled (to avoid multiply applying aperture correction). This fix indeed results in the correct order of operations, but it is far from elegant. This situation should be remedied as part of: https://jira.lsstcorp.org/browse/DM-5877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DetectAndMeasure make sure that all plugins that need aperture-
corrected fluxes get them. This requires running final measurement
in two phases after measuring aperture correction: one to apply
corrections, the other to run all remaining plugins. The need
for this is a misfeature that will be fixed as part of DM-5877.