Commits on May 12, 2016

1. Fix logic for applying aperture corrections (again) …

   With the current flow, the aperture corrections were being applied only
   after all the measurement plugins had run through, independent of their
   execution order.  This resulted in plugins whose measurements rely on
   aperture corrected fluxes (i.e. with execution order > APCORR_ORDER)
   being applied prior to the aperture correction, leading to erroneous
   results.  The only plugin currently affected by this is
   base_ClassificationExtendedness.
   
   We handle this here by running the measurement and aperture correction
   in DetectAndMeasure in three stages: first run all plugins up to order
   APCORR_ORDER to measure all fluxes; second run a step whose only action
   is to apply the aperture corrections to the fluxes measured in the
   first step; finally, run all remaining (APCORR_ORDER+1) plugins, whose
   measurements rely on aperture-corrected fluxes, but with aperture
   correction disabled (to avoid multiply applying aperture correction).
   
   This fix indeed results in the correct order of operations, but it is
   far from elegant.  This situation should be remedied as part of:
   https://jira.lsstcorp.org/browse/DM-5877

   

   laurenam committed May 12, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 7b41ccf
   • Browse repository at this point

   Copy the full SHA

   7b41ccf View commit details

   Browse the repository at this point in the history