DM-5877: Use Afterburners to clean up aperture correction logic #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| doc = "Match radius for matching icSourceCat objects to sourceCat objects (pixels)", | ||
| dtype=float, | ||
| default=3, | ||
| doc="Match radius for matching icSourceCat objects to sourceCat objects (pixels)", |
There was a problem hiding this comment.
Please don't include the above changes removing the spaces around the = unless it's in a separate commit.
natelust
force-pushed
the
tickets/DM-5877
branch
5 times, most recently
from
d13e5b3
to
2e63448
Compare
natelust
force-pushed
the
tickets/DM-5877
branch
from
2e63448
to
ff7a09a
Compare
Changes in meas_base remove the aperture corrrection subtask from the measurement logic. This nessesitates configuration changes to code that uses measurement tasks. In the process of making nessisary changes it was evident that the DetectAndMeasureTask was better seperated out into component tasks. All tasks which previously used DetectAndMeasure were modified to directly call the components they directly used.
As the functionality of this task is now called directly, the task, its tests, and examples are now removed
Each time the run method of a measurement task is executed, algorithm metadata is appended to the algorithm metadata object. Previously the run method of a measurement task was run multiple times for each dataID (due to limitations in applying aperture corrections). This lead to a behavior where every dataID had multiple entries for algorithm metadata. However, now each dataID now only adds one entry of metadata, and multiple entries will only be added by successive runs of multiple dataIDS. Because the number of values we be determined by the number of times the run method is executed, updates are necessary to handle varying numbers.
Tasks which now make use of forced measurements (Child classes of processImageForcedTask run aperture corrections by default now. The Mock coadds do not have reference fluxes, so disable aperture corrections for the forced task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.