Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-5877: Use Afterburners to clean up aperture correction logic #54

Merged
merged 5 commits into from
Jul 5, 2016
Merged

DM-5877: Use Afterburners to clean up aperture correction logic #54

merged 5 commits into from
Jul 5, 2016

Commits on Jul 5, 2016

  1. Formatting and coding standard changes

    @natelust
    natelust committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    74abca8 View commit details
    Browse the repository at this point in the history

  2. Refactor aperture corrections 

    Changes in meas_base remove the aperture corrrection subtask
from the measurement logic. This nessesitates configuration
changes to code that uses measurement tasks. In the process
of making nessisary changes it was evident that the
DetectAndMeasureTask was better seperated out into component
tasks. All tasks which previously used DetectAndMeasure were
modified to directly call the components they directly used.
    @natelust
    natelust committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    06cb1e3 View commit details
    Browse the repository at this point in the history

  3. Remove DetectAndMeasureTask 

    As the functionality of this task is now called directly,
the task, its tests, and examples are now removed
    @natelust
    natelust committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    40099a9 View commit details
    Browse the repository at this point in the history

  4. Update coadd unit test for new algMetadata behaivor 

    Each time the run method of a measurement task is executed, algorithm
metadata is appended to the algorithm metadata object. Previously the run
method of a measurement task was run multiple times for each dataID (due
to limitations in applying aperture corrections). This lead to a behavior
where every dataID had multiple entries for algorithm metadata. However,
now each dataID now only adds one entry of metadata, and multiple entries
will only be added by successive runs of multiple dataIDS. Because the
number of values we be determined by the number of times the run method
is executed, updates are necessary to handle varying numbers.
    @natelust
    natelust committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    b56de96 View commit details
    Browse the repository at this point in the history

  5. Update testCoadds for ApCorr in forced measurement 

    Tasks which now make use of forced measurements (Child classes of
processImageForcedTask run aperture corrections by default now. The
Mock coadds do not have reference fluxes, so disable aperture
corrections for the forced task.
    @natelust
    natelust committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    2638414 View commit details
    Browse the repository at this point in the history