Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34254: Validate psf configuration and output #672

Merged
merged 3 commits into from May 6, 2022
Merged

DM-34254: Validate psf configuration and output #672

merged 3 commits into from May 6, 2022

Conversation

parejkoj
Copy link
Contributor

No description provided.

ebellm
ebellm requested changes May 4, 2022
View reviewed changes
Copy link
Contributor

@ebellm ebellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should do the check you have in dcrAssembleCoadd.py in assembleCoadd.py as well.

@isullivan
Copy link
Contributor

In this case, the new check in dcrAssembleCoadd.py is for an option that does not exist in assembleCoadd.py

@parejkoj
Fail immediately if the psf is NaN
6958e94
@parejkoj
Check piffPsfDeterminer and psfCandidate kernelSize
e84e015 
Piff catastrophically fails if its kernelSize is larger than the input stamp
dimensions. I've added a check for that in piff itself, but it's better to
catch it before pipeline execution.
@parejkoj
Ensure piff and candidate psf sizes are appropriate to each other
6709e0a
@parejkoj parejkoj merged commit 89e8a13 into main May 6, 2022
@parejkoj parejkoj deleted the tickets/DM-34254 branch May 6, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebellm ebellm ebellm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parejkoj @isullivan @ebellm