Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34254: Validate psf configuration and output #672

Merged
merged 3 commits into from
May 6, 2022
Merged

DM-34254: Validate psf configuration and output #672

merged 3 commits into from
May 6, 2022

Commits on May 5, 2022

  1. Fail immediately if the psf is NaN

    @parejkoj
    parejkoj committed May 5, 2022
    Configuration menu
    Copy the full SHA
    6958e94 View commit details
    Browse the repository at this point in the history

  2. Check piffPsfDeterminer and psfCandidate kernelSize 

    Piff catastrophically fails if its kernelSize is larger than the input stamp
dimensions. I've added a check for that in piff itself, but it's better to
catch it before pipeline execution.
    @parejkoj
    parejkoj committed May 5, 2022
    Configuration menu
    Copy the full SHA
    e84e015 View commit details
    Browse the repository at this point in the history

  3. Ensure piff and candidate psf sizes are appropriate to each other

    @parejkoj
    parejkoj committed May 5, 2022
    Configuration menu
    Copy the full SHA
    6709e0a View commit details
    Browse the repository at this point in the history