DM-35551: fix ConfigurableAction tests and make serialization deterministic #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-35551
branch
2 times, most recently
from
19d3f08
to
2b33945
Compare
erykoff
approved these changes
Jul 14, 2022
|
It's in the commit message: the problem is that they weren't importable, and configs need to be in order to be deserialized (which the tests need to do). |
Tests for serialization were doing nothing, because: - the config values in the test were set up entirely by the class constructor, which is called directly before reading the saved config; - the test was using StringIO.read() instead of StringIO.getvalue(), which returns an empty string unless you seek back to the beginning of the buffer, and hence we were reading an empty string. But fixing that was nontrivial, because the classes used in those tests were defined in the test script, and hence weren't importable (and all config persistence needs to be able to import the config class and fields). So those test classes have been moved to a tests module.
TallJimbo
force-pushed
the
tickets/DM-35551
branch
from
2b33945
to
87c7504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.