Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35551: fix ConfigurableAction tests and make serialization deterministic #699

Merged
merged 2 commits into from
Jul 14, 2022
Merged

DM-35551: fix ConfigurableAction tests and make serialization deterministic #699

merged 2 commits into from
Jul 14, 2022

Commits on Jul 14, 2022

  1. Fix ConfigurableAction serialization tests. 

    Tests for serialization were doing nothing, because:

- the config values in the test were set up entirely by the class
  constructor, which is called directly before reading the saved
  config;
- the test was using StringIO.read() instead of StringIO.getvalue(),
  which returns an empty string unless you seek back to the beginning
  of the buffer, and hence we were reading an empty string.

But fixing that was nontrivial, because the classes used in those tests
were defined in the test script, and hence weren't importable (and all
config persistence needs to be able to import the config class and
fields).  So those test classes have been moved to a tests module.
    @TallJimbo
    TallJimbo committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    8c30337 View commit details
    Browse the repository at this point in the history

  2. Make ConfigurableAction persistence deterministic.

    @TallJimbo
    TallJimbo committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    87c7504 View commit details
    Browse the repository at this point in the history