DM-36198: Allow fakes propagation in postprocessing #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Sep 16, 2022
|
I think the original author wanted to specifically avoid using the word "fakes" because of the whole argument over what they should be called. As for how to do it, we could always start adding docstrings to |
Previously, MakeCcdVisitTableTask and MakeVisitTableTask allowed calexpType to be used for inputs (use case: fakes_calexp) but not outputs. Making the outputs match makes it possible run both fakes and non-fakes versions of these tasks in the same pipeline, though the only difference in output should be a few extra columns in the fakes version.
kfindeisen
force-pushed
the
tickets/DM-36198
branch
from
156a77a
to
21a12e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
calexpTypetemplate to the outputs ofMakeCcdVisitTableTaskandMakeVisitTableTask(they were added to inputs on 80aa66d). This makes it possible run both fakes and non-fakes versions of these tasks in the same pipeline, though the only difference in output should be a few extra columns in the fakes version.