DM-35901: Use the new lsst.utils.tests.ImportTestCase class for import test #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
reviewed
Jul 6, 2023
| "lsst.pipe.tasks", | ||
| "lsst.pipe.tasks.script", | ||
| "lsst.pipe.tasks.dataFrameActions", | ||
| } |
There was a problem hiding this comment.
Any reason this is a set instead of a tuple like elsewhere?
There was a problem hiding this comment.
I specifically defined PACKAGES to be an Iterable in the interface. set() has the advantage that duplicates will not be included. I can change it to a tuple if you prefer it.
erykoff
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires lsst/utils#165