DM-35901: Add new test case for importing every python file in a package #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
==========================================
+ Coverage 93.95% 93.97% +0.01%
==========================================
Files 43 44 +1
Lines 2831 2870 +39
==========================================
+ Hits 2660 2697 +37
- Misses 171 173 +2
☔ View full report in Codecov by Sentry. |
There are a couple of other places using %-format but those are generally cases where it's a bit cleaner to use than an f-string.
resources.contents() has been deprecated.
We are not required to support python 3.8 and the modern API for importlib.resources requires either python 3.9 or a dependency on the importlib_resources package.
This was referenced Jul 6, 2023
Merged
erykoff
reviewed
Jul 6, 2023
| try: | ||
| doImport(module_name) | ||
| except ImportError as e: | ||
| raise AssertionError(f"Error importing module {module_name}: {e}") from e |
There was a problem hiding this comment.
Is it possible to test the failing case? Maybe by writing out a junk python file to a temp directory?
There was a problem hiding this comment.
I'm not entirely sure how I would catch the failure since I'm not writing the test that is failing, the infrastructure is writing it and attaching it directly to this class.
erykoff
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes