DM-26874: rename pipetask2 to pipetask, remove old pipetask #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
reviewed
Oct 5, 2020
| @@ -52,8 +52,8 @@ fi | |||
| # can not be the same. | |||
| # Do not specify a number of processors (-j) to test that the default value | |||
| # works. | |||
| pipetask run -d "exposure=903342 AND detector=10" -b DATA_REPO/butler.yaml \ | |||
| -i HSC/calib,HSC/raw/all,refcats --longlog \ | |||
| pipetask --long-log run -d "exposure=903342 AND detector=10" -b DATA_REPO/butler.yaml \ | |||
There was a problem hiding this comment.
hmm, I thought we are keeping all options to be per-sub-command options?
There was a problem hiding this comment.
logging was an exception to this.
There was a problem hiding this comment.
I'm fine with that as long as there is a consensus. Initially pipetask had global options too, I'm glad we are going in circles 🙂
andy-slac
approved these changes
Oct 5, 2020
n8pease
force-pushed
the
tickets/DM-26874
branch
from
9e74abe
to
62a4824
Compare
It was changed from an option.
n8pease
force-pushed
the
tickets/DM-26874
branch
from
62a4824
to
3e6e7ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.