Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-26874: rename pipetask2 to pipetask, remove old pipetask #6

Merged
merged 2 commits into from
Oct 6, 2020
Merged

DM-26874: rename pipetask2 to pipetask, remove old pipetask #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0048bbf
use new pipetask
n8pease Oct 3, 2020
3e6e7ef
use instrument argument
n8pease Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions bin/run_demo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ fi
# ingestRaws.py doesn't search recursively; over-specifying to work around that.
if [ -z "$(find -L DATA_REPO/HSC/raw -type f)" ]; then
butler ingest-raws DATA_REPO input_data/HSC/raw/all/raw/r/HSC-R/
butler define-visits DATA_REPO -i HSC --collections HSC/raw/all
butler define-visits DATA_REPO HSC --collections HSC/raw/all
fi

# Pipeline execution will fail on second attempt because the output run
# can not be the same.
# Do not specify a number of processors (-j) to test that the default value
# works.
pipetask run -d "exposure=903342 AND detector=10" -b DATA_REPO/butler.yaml \
-i HSC/calib,HSC/raw/all,refcats --longlog \
pipetask --long-log run -d "exposure=903342 AND detector=10" -b DATA_REPO/butler.yaml \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I thought we are keeping all options to be per-sub-command options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging was an exception to this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with that as long as there is a consensus. Initially pipetask had global options too, I'm glad we are going in circles 🙂

--input HSC/calib,HSC/raw/all,refcats \
--register-dataset-types -p "${PIPE_TASKS_DIR}/pipelines/ProcessCcd.yaml" \
--instrument lsst.obs.subaru.HyperSuprimeCam --output-run demo_collection

Expand Down