OPSIM-1086: remove obsolete code and simplify upkeep of example_scheduler #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoachim
approved these changes
Oct 16, 2023
|
I tried to do them in separate commits, but for some of them it was a bit too entangled. |
rhiannonlynne
force-pushed
the
tickets/OPSIM-1086
branch
from
420ec75
to
e2379bf
Compare
…om sim configs, update docstrings
…here (should now match v3.3). Note the addition of sched_argparser (a version of which should be folded back into future scheduler config files, so we can just update this in-bulk in the future).
yoachim
force-pushed
the
tickets/OPSIM-1086
branch
from
e2379bf
to
65961d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was started to simplify some of the code in the footprints file (mostly, removing functions which were unused at this time and replaced by SkyAreaGenerators). Removing code which has names like
wfd_healpixelswhich could tempt users to try to define the WFD by these functions -- but that we don't keep up to date with current definitions -- seems like good preventative maintenance.And then I removed some extraneous code from the example_scheduler file, and wanted to be able to use the arg parser to set standard arguments for the baseline survey while using a notebook .. and maybe to keep the example_scheduler up to date with the evolving baseline more easily. So there are changes in this file as well.
I also moved some of what I see being used as standard changes to some of the keyword arguments for the sky_area classes into these classes directly. This should help avoid people missing these updates if they don't notice the kwarg being set in the simulation files.