Skip to content

Commit

Permalink
Return failure code on failure; DM-1027
Browse files Browse the repository at this point in the history
  • Loading branch information
@RobertLuptonTheGood
RobertLuptonTheGood committed Aug 15, 2014
1 parent cd8b803 commit 83774cd
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions python/lsst/sconsUtils/tests.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,13 @@ def run(self, fileGlob):
@printf "%%s" 'running ${SOURCES}... ';
@echo $SOURCES %s > $TARGET; echo >> $TARGET;
@if %s $SOURCES %s >> $TARGET 2>&1; then \
if ! %s; then mv $TARGET ${TARGET}.failed; fi; \
echo "%s"; \
if ! %s; then mv $TARGET ${TARGET}.failed; exit 1; fi; \
else \
if ! %s; then mv $TARGET ${TARGET}.failed; fi; \
echo "%s"; \
if ! %s; then mv $TARGET ${TARGET}.failed; exit 1; fi; \
fi;
""" % (expandedArgs, interpreter, expandedArgs, should_pass, passedMsg, should_fail, failedMsg))
""" % (expandedArgs, interpreter, expandedArgs, passedMsg, should_pass, failedMsg, should_fail))

targets.extend(result)

Expand Down

1 comment on commit 83774cd

@ktlim
Copy link
Contributor

@ktlim ktlim commented on 83774cd Aug 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK as far as it goes, but the problem is getting all the tests to execute after one fails.
I think it's going to involve having the scons Command execute a script to run all the tests after building them all, rather than the per-test Commands we now have.

Please sign in to comment.