DM-33814: Add type annotations to version.py #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__version_info__ is not included because that is a Tuple and the import from typing should only happen if __version__info__ is being included.
TallJimbo
approved these changes
Feb 25, 2022
| submodule_search_locations=None, | ||
| loader=loader) | ||
| module = importlib.util.module_from_spec(spec) | ||
| spec.loader.exec_module(module) |
There was a problem hiding this comment.
FWIW, I'm not sure why I used imp here in the first place; it's certainly conceivable that something like this would also work:
with open(filename, "r") as buffer:
vars = {}
exec(buffer.read(), vars)
module = SimpleNamespace(**vars) # not really a module, but close enough
There was a problem hiding this comment.
Incredibly the way I'm doing it seems to be the documented approach. I couldn't believe it myself. I'm sure you used imp because it was the default old way to do it.
There was a problem hiding this comment.
Pondering this, I think I'm fine with the documented importlib approach rather than using SimpleNamespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed a warning from use of the deprecated
imppackage.