DM-34666: Set macOS deployment target to 11.0 on ARM systems #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11.0 is the oldest OS version that supports arm64.
timj
force-pushed
the
tickets/DM-34666
branch
2 times, most recently
from
563b311
to
7105f4d
Compare
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage ? 19.73%
=======================================
Files ? 18
Lines ? 1956
Branches ? 519
=======================================
Hits ? 386
Misses ? 1536
Partials ? 34 Continue to review full report at Codecov.
|
timj
commented
May 4, 2022
ktlim
approved these changes
May 5, 2022
|
Actually, given the theme of this ticket, why not an OS matrix with |
|
It seems barely worth the effort to also build on macos given that the tests don't try to build a C++ interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11.0 is the oldest OS version that supports arm64.