DM-35792: Check config existence before making it a dependency. #110
Conversation
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 19.73% 19.72% -0.02%
==========================================
Files 18 18
Lines 1956 1957 +1
Branches 519 520 +1
==========================================
Hits 386 386
- Misses 1536 1537 +1
Partials 34 34
Continue to review full report at Codecov.
|
| self.results.extend(config) | ||
| if os.path.exists(config): | ||
| env.Depends(doc, config) | ||
| self.results.extend(config) |
There was a problem hiding this comment.
I'm trying to understand this change for DM-35793, and I've managed to get very confused.
At first glance, this looks like a shadowing problem (config refers to two different objects over the lifetime of the function), but on second thought the original code makes a lot more sense.
At this point, config is a Command object that, if the doxygen.conf.in file is missing, has a target (doxygen.conf) but no source. So it seems strange that calling env.Depends on this object would introduce a dependency on doxygen.conf.in when the object appears to have been constructed to not know about it. Instead, the new code looks like it avoids creating doxygen.conf entirely, which I assume is still needed to get the right dependencies (tag files), base.inc setttings, etc.
Am I missing something?
No description provided.