Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36237: Pass through http proxy variables to tests. #112

Merged
merged 2 commits into from Sep 14, 2022
Merged

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Sep 14, 2022

This allows scons tests to run on USDF and other locations that need proxies to connect to the internet for tests that it (including anything with astropy.time).

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 19.73% // Head: 19.73% // No change to project coverage 👍

Coverage data is based on head (2a1998c) compared to base (940f518).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   19.73%   19.73%           
=======================================
  Files          18       18           
  Lines        1956     1956           
  Branches      519      519           
=======================================
  Hits          386      386           
  Misses       1536     1536           
  Partials       34       34           
Impacted Files Coverage Δ
python/lsst/sconsUtils/tests.py 11.11% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj
Copy link
Member

timj commented Sep 14, 2022

Don't worry about the code coverage. I think we need to work out how to have code coverage for the scons command itself that runs the tests.

@erykoff erykoff merged commit b98748c into main Sep 14, 2022
@erykoff erykoff deleted the tickets/DM-36237 branch September 14, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants