DM-38499: Clean up package and change to run flake8/ruff #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 5 5
Lines 32 32
Branches 2 2
=======================================
Hits 28 28
Misses 2 2
Partials 2 2
☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-38499
branch
9 times, most recently
from
1874e05
to
dd27a7d
Compare
2 tasks
ktlim
reviewed
Jul 5, 2023
.pre-commit-config.yaml
Outdated
| # supported by your project here, or alternatively use | ||
| # pre-commit's default_language_version, see | ||
| # https://pre-commit.com/#top_level-default_language_version | ||
| language_version: python3.10 |
There was a problem hiding this comment.
If latest is python3.11, how come this is python3.10?
There was a problem hiding this comment.
Formally we are still on python 3.10 although if this isn't merging until python 3.11 is the standard then I can change that.
There was a problem hiding this comment.
Oh, I see you're reading "supported" differently from the way I did (the highest level in your matrix).
ktlim
approved these changes
Jul 5, 2023
No need for it to be checking for the python2 config parser.
ruff is preferred over flake8 but will only be used if a ruff configuration is found. No attempt is made to check that ruff or flake8 are present in the path.
This allows the variables to be inlined in the large string.
tomllib is standard package with python 3.11.
black broke it up because of a trailing comma but there is no need for it.
This makes it easier to run on jenkins with python 3.10.
sconsUtils only has to work with current rubin-env
miniconda is broken on python 3.11 + macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not be merged until we update to rubin-env 7 so that we have the fast flake8 and ruff available. Potentially this PR could be split into two: one for running flake8/ruff and the other all the cleanups.