Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40033: Exclude tests/.tests when running linters #116

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

timj
Copy link
Member

@timj timj commented Jul 14, 2023

No description provided.

timj added 2 commits July 14, 2023 08:58
ruff will ignore it automatically when this is a git repo but
will not when it's a source distribution.
@timj
Copy link
Member Author

timj commented Jul 14, 2023

I did just notice that the code we have in __init__.py that expects the code to only be imported via SCons is no longer relevant because in the conda SCons you can import that package any time you want.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (88b277b) 87.50% compared to head (3be1503) 87.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files           5        5           
  Lines          32       32           
  Branches        2        2           
=======================================
  Hits           28       28           
  Misses          2        2           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj merged commit 1f1c806 into main Jul 14, 2023
9 checks passed
@timj timj deleted the tickets/DM-40033 branch July 14, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants