Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also skip bin directory with ruff #117

Merged
merged 1 commit into from Jul 21, 2023
Merged

Also skip bin directory with ruff #117

merged 1 commit into from Jul 21, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jul 20, 2023

Need this until ruff adds support for .gitignore outside of a git repo. (astral-sh/ruff#5930).

@timj timj requested a review from erykoff July 20, 2023 21:37
@erykoff
Copy link
Contributor

erykoff commented Jul 20, 2023

I have no idea what is going on with the test testing itself and failing.

Need this until ruff adds support for .gitignore outside of
a git repo.
@timj
Copy link
Member Author

timj commented Jul 20, 2023

I had a #noqa in a comment explaining my motivation so obviously it complained about the noqa that was unused...

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1f1c806) 87.50% compared to head (ce95b49) 87.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files           5        5           
  Lines          32       32           
  Branches        2        2           
=======================================
  Hits           28       28           
  Misses          2        2           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj merged commit 80c3e6a into main Jul 21, 2023
9 checks passed
@timj timj deleted the tickets/DM-40138 branch July 21, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants