DM-42999: Enable Boost Timer version 2 in production code #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 5 5
Lines 42 42
Branches 3 3
=======================================
Hits 36 36
Misses 3 3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
kfindeisen
force-pushed
the
tickets/DM-42999
branch
from
e758849
to
75c8a35
Compare
|
Sorry for the force-push! I realized at the last minute that the original PR was wrong; |
parejkoj
approved these changes
Feb 29, 2024
Previously, Boost Timer version 2 was only used for afw unit tests. In order to migrate ip_diffim (which times production code) from Timer version 1 to version 2, the compiled library must be available in main.
kfindeisen
force-pushed
the
tickets/DM-42999
branch
from
75c8a35
to
7d38026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the compiled library from Boost Timer 2 to be used in production code, not just test code (version 1 of the library was header-only). It must be merged before lsst/ip_diffim#298.