Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask python on path where it is located #19

Merged
merged 1 commit into from Aug 4, 2016
Merged

Ask python on path where it is located #19

merged 1 commit into from Aug 4, 2016

Conversation

timj
Copy link
Member

@timj timj commented Aug 4, 2016

Do not ask the Python running SCons for its sys.executable.

This is needed when we do not know if the SCons python is the
same python we wish to use to run the applications built by
SCons.



def whichPython():
# Call out to "python" and ask it where it is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a docstring instead of a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was being consistent with the usage in the rest of the file which seems to use a comment @brief and no docstring.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh. ):

This is why changing coding standards in mid-stream is a bad idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that sconsUtils is special because pydoc won't run on the file and you have to use doxygen. The file can't be imported unless it is being imported by SCons.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that sconsUtils is special because pydoc won't run on the file and you have to use doxygen. The file can't be imported unless it is being imported by SCons.

Right. That itself doesn't preclude using docstrings, but back when I originally wrote sconsUtils I didn't know about (or Doxygen didn't support) prefixing docstrings with "!" to make it parse the markup, so I thought comments were the only way to do that.

Do not ask the Python running SCons for its sys.executable.

This is needed when we do not know if the SCons python is the
same python we wish to use to run the applications built by
SCons.
@timj timj merged commit a3c03f4 into master Aug 4, 2016
@ktlim ktlim deleted the tickets/DM-6319 branch August 25, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants