Fix lack of sorting in SourcesForSharedLibrary. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorting wasn't working before, leading to spurious rebuilds due to dependency order changes when the list of top-level build targets changes. I'm not sure all of these changes are necessary to fix it - using Flatten() may have been all we needed - but sorting by str certainly makes it easier to debug (without that it's not clear how scons sorts File objects) and always returning SharedObjects avoids having any intermediate steps where the sort order could get messed up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting wasn't working before, leading to spurious rebuilds due to
dependency order changes when the list of top-level build targets
changes.
I'm not sure all of these changes are necessary to fix it - using
Flatten() may have been all we needed - but sorting by str certainly
makes it easier to debug (without that it's not clear how scons sorts
File objects) and always returning SharedObjects avoids having any
intermediate steps where the sort order could get messed up.