Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-10448: Make the generated versions.py file PEP8 compliant #31

Merged
merged 1 commit into from May 5, 2017
Merged

DM-10448: Make the generated versions.py file PEP8 compliant #31

merged 1 commit into from May 5, 2017

Conversation

timj
Copy link
Member

@timj timj commented May 3, 2017

  • Fix the first comment line
  • Spread the __all__ entry over multiple lines to prevent them from growing too long.

@timj timj requested a review from r-owen May 3, 2017 22:03
r-owen
r-owen approved these changes May 5, 2017
View reviewed changes
Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look very sensible.

@timj timj merged commit 243816e into master May 5, 2017
@ktlim ktlim deleted the tickets/DM-10448 branch August 25, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-owen r-owen r-owen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @r-owen