DM-8560: Port sconsUtils to Python 3 #32
Conversation
Rather than reading lines and then converting to bytes.
timj
changed the title
python/lsst/sconsUtils/state.py
Outdated
| try: | ||
| from configparser import ConfigParser | ||
| except ImportError: | ||
| from ConfigParser import ConfigParser |
There was a problem hiding this comment.
These two bits are a py2/3 compatibility thing, no? Might be worth a comment to that effect so we can find it and cleanup when the "all-py3" days are upon us.
There was a problem hiding this comment.
Sure, although it's a completely standard compatibility shim.
python/lsst/sconsUtils/utils.py
Outdated
| @@ -136,6 +136,7 @@ def libraryLoaderEnvironment(): | |||
| # @brief Safe wrapper for running external programs, reading stdout, and sanitizing error messages. | |||
| # | |||
| # Note that the entire program output is returned, not just a single line. | |||
| # Returns strings not bytes | |||
There was a problem hiding this comment.
Should this be a proper @return docstring, with some more explanation?
There was a problem hiding this comment.
sconsUtils code explicitly does not use standard docstrings. I think it's because pydoc can't parse the files (because the files can never be imported unless scons is active). I will fix the space problem though.
There was a problem hiding this comment.
Ah, I see what you mean. Doxygen @return. Ok, that is used elsewhere in sconsUtils.
No description provided.