DM-12014: Use clang if no compiler was given and gcc is clang #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid confusion by using clang if this is really clang rather than using gcc.
timj
changed the title
PaulPrice
reviewed
Sep 25, 2017
| # If we have picked up a default compiler called gcc that is really | ||
| # clang, we call it clang to avoid confusion (gcc on macOS has subtly | ||
| # different options) | ||
| if not env['cc'] and env.whichCc == "clang" and env['CC'] == "gcc": |
There was a problem hiding this comment.
env['cc'] is empty, but env['CC'] is not.... Confusing! (Not your fault!)
Might env['CC'] be gcc with some extra version cruft, e.g., gcc-4.8.4?
There was a problem hiding this comment.
env['cc'] is the external command line override for the compiler and env['CC'] is the compiler that we are actually using. If there is extra cruft in the gcc name then it's highly likely that this is not a clang -- if it is a clang then it makes no sense for it to be a gcc-n.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid confusion by using clang if this is really clang rather than using gcc.
Without this if you type
sconsyou getgccbut it's reallyclang.