DM-13910: make compiler check fire only when needed #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Mar 29, 2018
The compiler check in lsst.sconsUtils.state._configureCommon fires whenever you import lsst.sconsUtils, even if you don't have any C++ code and all you want out of lsst.sconsUtils is some utility completely unrelated to C++. Besides just wasting time, this makes it difficult to run ci_hsc on a cluster nodes that don't have the latest gcc installed. Instead, have the compiler check only fire when we need it, as defined by instantiating BasicSConstruct. The compiler check can also be disabled when using BasicSConstruct by instantiating it with disableCc=True.
PaulPrice
force-pushed
the
tickets/DM-13910
branch
from
0d2ae6b
to
22e3848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler check in lsst.sconsUtils.state._configureCommon
fires whenever you import lsst.sconsUtils, even if you don't
have any C++ code and all you want out of lsst.sconsUtils is
some utility completely unrelated to C++. Besides just wasting
time, this makes it difficult to run ci_hsc on a cluster nodes
that don't have the latest gcc installed.
Instead, have the compiler check only fire when we need it, as
defined by instantiating BasicSConstruct. The compiler check
can also be disabled when using BasicSConstruct by instantiating
it with disableCc=True.