Split file and directory cleaning patterns. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
requested changes
Aug 31, 2018
python/lsst/sconsUtils/builders.py
Outdated
| (files_expr, file_action) | ||
| filesExpr += "-name %s" % re.sub(r"(^|[^\\])([\[*])", r"\1\\\2", filePattern) | ||
| action = "find %s" % directory | ||
| action += r" \( -name .svn -prune -o -name .git -prune -o -name \* \) " |
There was a problem hiding this comment.
There's a lot of duplication in these two cases. Same pruning, same regex substitution. Can there be a little helper function that you can create here to reduce code duplication?
python/lsst/sconsUtils/builders.py
Outdated
| filesExpr += "-name %s" % re.sub(r"(^|[^\\])([\[*])", r"\1\\\2", filePattern) | ||
| action = "find %s" % directory | ||
| action += r" \( -name .svn -prune -o -name .git -prune -o -name \* \) " | ||
| action += r" \( %s \) -exec rm -f {} \;" % filesExpr |
There was a problem hiding this comment.
Would it be safer to use -type f here and -type d below?
ktlim
force-pushed
the
tickets/DM-15530
branch
from
56b7370
to
22a372d
Compare
|
Better now? Should I add |
timj
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.