DM-10384: builder helper for one-module-per-package pybind11 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Sep 25, 2018
python/lsst/sconsUtils/scripts.py
Outdated
| return result | ||
|
|
||
| ## | ||
| # @brief Convenience function to replace standard python/*/SConscript boilerplate. | ||
| # | ||
| # @deprecated Use BasicSConstrcipt.python() for new code with all source |
There was a problem hiding this comment.
Unimportant typo here in BasicSconscript.
ktlim
reviewed
Sep 26, 2018
python/lsst/sconsUtils/scripts.py
Outdated
| @@ -330,39 +330,41 @@ def rewrite_shebang(target, source, env): | |||
| # | |||
| # With no arguments, this will build a SWIG module with the name determined according | |||
parejkoj
reviewed
Sep 28, 2018
| return result | ||
|
|
||
| ## | ||
| # @brief Convenience function to replace standard python/*/SConscript boilerplate. | ||
| # | ||
| # @deprecated Use BasicSConscript.python() for new code with all source |
There was a problem hiding this comment.
Is there a rough "deprecated until" date you could assign to this one? "When the last lsst package is converted to the new style" would be good enough for me, but we should try to be more explicit about deprecation durations.
There was a problem hiding this comment.
The "when the last packages is converted" is probably the best I can promise, but I'll add that.
We no longer need Swig support, and this avoids clashes with the now-deprecated BasicSConscript.pybind11 function.
TallJimbo
force-pushed
the
tickets/DM-10384
branch
from
61c6bf9
to
fe194e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.