DM-16220: Use subprocess.run for all external commands #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
changed the title
|
Turns out that python 3.7 has a significantly better |
ktlim
reviewed
Oct 18, 2018
python/lsst/sconsUtils/utils.py
Outdated
|
|
||
| try: | ||
| retval = subprocess.run(cmd, shell=shell, stdout=subprocess.PIPE, stderr=subprocess.PIPE, | ||
| check=True, text=True) |
There was a problem hiding this comment.
Wait, I thought 3.6 doesn't support text. You need universal_newlines, I think.
timj
force-pushed
the
tickets/DM-16220
branch
from
307ad11
to
0919f11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize on the modern way for running external commands.