Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-23798: Fix scons install of bin #75

Merged
merged 1 commit into from Mar 7, 2020
Merged

DM-23798: Fix scons install of bin #75

merged 1 commit into from Mar 7, 2020

Conversation

PaulPrice
Copy link
Contributor

No description provided.

@PaulPrice PaulPrice requested a review from timj March 6, 2020 17:36
timj
timj approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying that we've not been installing the scripts if there is no pre-existing bin directory? Gosh.

@PaulPrice
Copy link
Contributor Author

Depends on how the install is done. scons && scons install will install the bin scripts. Plain scons install will not.

@PaulPrice
Copy link
Contributor Author

I suspect we've been doing scons && scons install, possibly because of this very issue.

@PaulPrice
Copy link
Contributor Author

Just checked: we have been doing scons && scons install because eupspkg has separate build and install steps.

@PaulPrice
fix install of bin
1c66313 
'scons install' would not install the 'bin' directory
unless it already existed, but it is usually created
by the 'shebang' target. Add it explicitly if we're
going to end up creating it.
@PaulPrice PaulPrice merged commit 80d1608 into master Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PaulPrice @timj