DM-23835: Support conda compilers and conda third parties #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bbb8eb2)
timj
reviewed
Apr 24, 2020
Added RPATH and _RPATH Added platform check for rpath Added /usr/lib to LIBPATH Cleanup config strategy in dependencies.py (cherry picked from commit 8ea99a0) (cherry picked from commit b27c020) (cherry picked from commit fd53b11) (cherry picked from commit 26c5f50) (cherry picked from commit 8d76b84) (cherry picked from commit 6c60b75) (cherry picked from commit 04681ed) (cherry picked from commit acb9aca) (cherry picked from commit 74ec0aa) (cherry picked from commit e182b37) (cherry picked from commit 445f6cc) (cherry picked from commit b2fd8de8f052360cb9f3438233c1f6f11ae4c413) (cherry picked from commit a1efdfc1ee09e99b489540974ce68710ed8a87ef) (cherry picked from commit 3f81ead68fc693be95842f42c85e4ec0e803cadd) (cherry picked from commit 713be2950d6e2712fc5c7d88de9becac4d6290c0) (cherry picked from commit 3a59533)
(cherry picked from commit 8ae2a03)
(cherry picked from commit df93a7e76a60aedc6636b56a0c7e1b78bffc927e) (cherry picked from commit 0ba9545)
(cherry picked from commit 6a77d6c36921e9ec87168017d81b527f288579dc) (cherry picked from commit fd14d50)
(cherry picked from commit d2c0397e815c3c712af3cf3d9684629ee782bc09) (cherry picked from commit 4c0cbb4)
(cherry picked from commit 53d5a01a8c543b1006175a0d381cebb51c42770e) (cherry picked from commit a4651ca)
(cherry picked from commit c58a830ce48fa7395a76492626b384c38fa12522) (cherry picked from commit 0c1fbb6)
(cherry picked from commit b629a20)
(cherry picked from commit 17aee87)
(cherry picked from commit 0bc8c03)
(cherry picked from commit df93a7e76a60aedc6636b56a0c7e1b78bffc927e) (cherry picked from commit 0ba9545)
brianv0
force-pushed
the
tickets/DM-23835
branch
2 times, most recently
from
55884f0
to
b064bf9
Compare
Add note about RPATHs Fixup
brianv0
force-pushed
the
tickets/DM-23835
branch
from
b064bf9
to
df9eef9
Compare
brianv0
force-pushed
the
tickets/DM-23835
branch
from
606b425
to
a2d92fa
Compare
gcomoretto
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cfg files for third parties in the config directory.
It also contains logic to support those config files.
In addition, it has additional support for
CONDA_BUILD_SYSROOTfor the conda compilers, especially on macOS, and it will prefer using conda compilers if it encountersCONDA_BUILD_SYSROOT