List failed tests and the content of the .failed files #8
Conversation
We list the failed tests after dumping the contents of the .failed files so that eups distrib will be able to report the failed tests properly. Switch to .format() for string formatting so as to not repeat "testsDir" four distinct times.
| if [ $$nfail -gt 0 ]; then \ | ||
| echo "Failed test output:" >&2; \ | ||
| find {0} -name \*.failed -exec cat {{}} \; >&2; \ |
There was a problem hiding this comment.
The >&2; has essentially no effect. It probably needs to be something like find {0} -name \*.failed -exec cat {} \; | cat >&2 (may require some fiddling).
There was a problem hiding this comment.
Although this code does do what I want: send the output to the log files.
There was a problem hiding this comment.
I've done some experimentation and that >&2 does work as I expect so I don't think this needs to be changed.
There was a problem hiding this comment.
@jhoblitt What's your objection to the >&2? I would have naively thought that would work fine.
There was a problem hiding this comment.
Spoke to @jhoblitt and the confusion was over the escaped semi-colon that goes with the -exec and is not actually a command separator. There is no issue.
There was a problem hiding this comment.
This was a comprehension failure on my part -- I was thrown off by the escape line endings and didn't catch that the escaped ; was part of the -exec arg. @timj and I just discussed this and I think it's good as-is.
|
👍 |
We list the failed tests after dumping the contents of the
.failed files so that eups distrib will be able to report
the failed tests properly.
Switch to .format() for string formatting so as to not repeat
"testsDir" four distinct times.