Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-29139: Update ignore glob in pytest test collection to include *.tmp #86

Merged
merged 2 commits into from Mar 11, 2021

Conversation

timj
Copy link
Member

@timj timj commented Mar 11, 2021

This reverses #85 and tries a different solution. The race condition always seems to involve .tmp files so target those explicitly.

This reverts commit 9f7e3fc.

This change did not fix the problem so backing it out to try
something different.
These can come from compilation steps that are still happening
when pytest starts.
@timj timj requested a review from ktlim March 11, 2021 00:54
Copy link
Contributor

@ktlim ktlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this, but I'm worried that there are lots of other files (.os, .so, etc.) that are created by compilers, so this may just move the problem as well.

@timj timj merged commit 8076a8c into master Mar 11, 2021
@timj timj deleted the tickets/DM-29139a branch March 11, 2021 03:08
@timj
Copy link
Member Author

timj commented Mar 11, 2021

We'll add more as we need them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants