New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github pages based schema browser #25
Conversation
Three quick comments:
|
<ul> | ||
<li><a href=".">Schema Browser</a></li> | ||
<ul> | ||
<li><a href="">{{ page.title }}</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the hash or tag/version somewhere? Are we ever going to need to refer to past versions of sdm_schemas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is a (the most?) serious drawback of this approach: one version (master/main) only. Something based on lsst-the-docs would be superior in this regard. This solution is proposed as a low effort stopgap.
Please make sure to select "Enforce HTTPS" in the GitHub Pages settings. |
Would need to add a little JS for both of ^these, I think? I (or other) could pursue this on a subsequent ticket. (That said, perhaps that effort would be better spent looking into a replacement solution based on e.g. lsst-the-docs.)
Hmm, that seems a significant lacuna in Felis? |
wilco |
9d1fd5e
to
6881101
Compare
6881101
to
d1e34ff
Compare
d1e34ff
to
8507e75
Compare
8507e75
to
19cbc82
Compare
We could deploy this to LSST the Docs instead quite easily (it's what Rubin uses instead of GitHub Pages). Just let me know if you want to do that. |
Thanks @jonathansick -- that is certainly probably best in the end, but I was unsure what exactly was needed. In particular, ability to select versions rendered from different tags/branches would be pretty useful. And, of course, being stylistically aligned with everything else is also always a plus. Would we want to rework to some other rendering system than Jekyll for that? |
This is a functional replacement for the now-decommissioned statically-rendered schema browser, built on github pages for the sdm_schemas repo.
Github handles the rendering and serving of the pages, updating them automatically when commits are made to master in the sdm_schemas repo. No additional tooling, services, workflow, or github actions are required. The schema pages are rendered directly from the felis yamls within the repository, which are easily consumed and processed by the jekyll site generator used by github pages.
The main adds here are a top-level
_config.yml
file, and a newbrowser/
subdirectory which contains the jekyll config and templates. Schemas made visible in the browser are curated by providing a short markdown description for each desired to be shown in thebrowser/
subdirectory (seebaseline.md
,dp01.md
, andhsc.md
in this PR for examples.) A cleanup commit removing obsolete filesand pushing others into ais also included here.deprecated/
subdirectoryFor a live example of these pages, see https://fritzm.github.io/sdm_schemas/browser which is running out of a clone of sdm_schemas where these changes are merged to master and github pages have been enabled. If this PR is merged, turning on github pages on the sdm_schemas repo will make the schema browser appear at https://lsst.github.io/sdm_schemas/browser.