DM-34136: Initial version of Visit and CcdVisit for dp0.2.

[ctslater]

No description provided.

[iagaponenko]

MySQL doesn't have the numeric data type long. For signd 64-bit numbers you need to add the following attribute:

mysql:datatype: BIGINT

For 32-bit numbers:

mysql:datatype: INT

For unsigned types:

mysql:datatype: BIGINT UNSIGNED

or:

mysql:datatype: INT UNSIGNED

[iagaponenko]

I would argue that MySQL-specific type definitions were added for each column of the schema, such as:

mysql:datatype: CHAR(32)

And, perhaps, in case strings are not exactly 32-character long a better option would be:

mysql:datatype: VARCHAR(32)

This would save quite a bit of space for very large tables.

[iagaponenko]

mysql:datatype: DOUBLE

[iagaponenko]

Please, provide the following attribute for all columns:

mysql:datatype: 

[ctslater]

I have pushed a new commit, but the fixes it contains are unrelated from the review comments.

I think that all of the changes that Igor is asking for are already accounted for in the mysql DDL that Felis generates. You can check this by running felis create-all --dry-run --engine-url 'mysql://localhost/blah' dp02_dc2.yaml, but for convenience I'll just paste the output here:

CREATE TABLE `dp02_test_PREOPS863_00`.`Visit` (
        visit BIGINT COMMENT '', 
        physical_filter CHAR(32) COMMENT '', 
        band CHAR(1) COMMENT '', 
        ra DOUBLE COMMENT '', 
        decl DOUBLE COMMENT '', 
        `skyRotation` DOUBLE COMMENT '', 
        azimuth DOUBLE COMMENT '', 
        altitude DOUBLE COMMENT '', 
        `zenithDistance` DOUBLE COMMENT '', 
        airmass DOUBLE COMMENT '', 
        `obsStart` TIMESTAMP NULL COMMENT '', 
        `expTime` DOUBLE COMMENT ''
)COMMENT='';

CREATE TABLE `dp02_test_PREOPS863_00`.`CcdVisit` (
        `visitId` BIGINT COMMENT '', 
        physical_filter CHAR(32) COMMENT '', 
        band CHAR(1) COMMENT '', 
        ra DOUBLE COMMENT '', 
        decl DOUBLE COMMENT '', 
        `zenithDistance` FLOAT COMMENT '', 
        `zeroPoint` FLOAT COMMENT '', 
        `psfSigma` FLOAT COMMENT '', 
        `skyBg` FLOAT COMMENT '', 
        `skyNoise` FLOAT COMMENT '', 
        detector BIGINT COMMENT '', 
        seeing DOUBLE COMMENT '', 
        `skyRotation` DOUBLE COMMENT '', 
        `expMidpt` TIMESTAMP NULL COMMENT '', 
        `expTime` DOUBLE COMMENT '', 
        `obsStart` TIMESTAMP NULL COMMENT '', 
        `darkTime` DOUBLE COMMENT '', 
        `xSize` BIGINT COMMENT '', 
        `ySize` BIGINT COMMENT '', 
        llcra DOUBLE COMMENT '', 
        llcdec DOUBLE COMMENT '', 
        ulcra DOUBLE COMMENT '', 
        ulcdec DOUBLE COMMENT '', 
        urcra DOUBLE COMMENT '', 
        urcdec DOUBLE COMMENT '', 
        lrcra DOUBLE COMMENT '', 
        lrcdec DOUBLE COMMENT ''
)COMMENT='';

The only remaining issue I see is that Felis doesn't seem to be using the mysql:datatype override on the DATETIME columns, but that's a felis bug and will have to be fixed separately. I don't think that's a blocker on merging this though, since the tables are already ingested?

[iagaponenko]

Provided Felise generates the correct MySQL schema from this definition, this PR looks good to me.