Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34136: Initial version of Visit and CcdVisit for dp0.2. #47

Merged
merged 2 commits into from
Apr 12, 2022
Merged

DM-34136: Initial version of Visit and CcdVisit for dp0.2. #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a706f
Initial version of Visit and CcdVisit for dp0.2.
ctslater Mar 21, 2022
cd48e37
Fix floats that were mistakenly marked as (integer) longs.
ctslater Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
174 changes: 174 additions & 0 deletions yml/dp02_dc2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8236,3 +8236,177 @@ tables:
datatype: long
mysql:datatype: BIGINT
description:
- name: Visit
'@id': '#Visit'
description: ''
columns:
- name: visit
'@id': '#Visit.visit'
datatype: long
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MySQL doesn't have the numeric data type long. For signd 64-bit numbers you need to add the following attribute:

mysql:datatype: BIGINT

For 32-bit numbers:

mysql:datatype: INT

For unsigned types:

mysql:datatype: BIGINT UNSIGNED

or:

mysql:datatype: INT UNSIGNED

description: ''
- name: physical_filter
'@id': '#Visit.physical_filter'
datatype: char
length: 32
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that MySQL-specific type definitions were added for each column of the schema, such as:

mysql:datatype: CHAR(32)

And, perhaps, in case strings are not exactly 32-character long a better option would be:

mysql:datatype: VARCHAR(32)

This would save quite a bit of space for very large tables.

description: ''
- name: band
'@id': '#Visit.band'
datatype: char
length: 1
description: ''
- name: ra
'@id': '#Visit.ra'
datatype: double
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

mysql:datatype: DOUBLE

description: ''
- name: decl
'@id': '#Visit.decl'
datatype: double
description: ''
- name: skyRotation
'@id': '#Visit.skyRotation'
datatype: double
description: ''
- name: azimuth
'@id': '#Visit.azimuth'
datatype: double
description: ''
- name: altitude
'@id': '#Visit.altitude'
datatype: double
description: ''
- name: zenithDistance
'@id': '#Visit.zenithDistance'
datatype: double
description: ''
- name: airmass
'@id': '#Visit.airmass'
datatype: double
description: ''
- name: obsStart
'@id': '#Visit.obsStart'
datatype: timestamp
length: 6
mysql:datatype: DATETIME(6)
description: ''
- name: expTime
'@id': '#Visit.expTime'
datatype: double
description: ''
- name: CcdVisit
'@id': '#CcdVisit'
description: ''
columns:
- name: visitId
'@id': '#CcdVisit.visitId'
datatype: long
description: ''
- name: physical_filter
'@id': '#CcdVisit.physical_filter'
datatype: char
length: 32
description: ''
- name: band
'@id': '#CcdVisit.band'
datatype: char
length: 1
description: ''
- name: ra
'@id': '#CcdVisit.ra'
datatype: double
description: ''
- name: decl
'@id': '#CcdVisit.decl'
datatype: double
description: ''
- name: zenithDistance
'@id': '#CcdVisit.zenithDistance'
datatype: float
description: ''
- name: zeroPoint
'@id': '#CcdVisit.zeroPoint'
datatype: float
description: ''
- name: psfSigma
'@id': '#CcdVisit.psfSigma'
datatype: float
description: ''
- name: skyBg
'@id': '#CcdVisit.skyBg'
datatype: float
description: ''
- name: skyNoise
'@id': '#CcdVisit.skyNoise'
datatype: float
description: ''
- name: detector
'@id': '#CcdVisit.detector'
datatype: long
description: ''
- name: seeing
'@id': '#CcdVisit.seeing'
datatype: double
description: ''
- name: skyRotation
'@id': '#CcdVisit.skyRotation'
datatype: double
description: ''
- name: expMidpt
'@id': '#CcdVisit.expMidpt'
datatype: timestamp
length: 6
mysql:datatype: DATETIME(6)
description: ''
- name: expTime
'@id': '#CcdVisit.expTime'
datatype: double
description: ''
- name: obsStart
'@id': '#CcdVisit.obsStart'
datatype: timestamp
length: 6
mysql:datatype: DATETIME(6)
description: ''
- name: darkTime
'@id': '#CcdVisit.darkTime'
datatype: double
description: ''
- name: xSize
'@id': '#CcdVisit.xSize'
datatype: long
description: ''
- name: ySize
'@id': '#CcdVisit.ySize'
datatype: long
description: ''
- name: llcra
'@id': '#CcdVisit.llcra'
datatype: double
description: ''
- name: llcdec
'@id': '#CcdVisit.llcdec'
datatype: double
description: ''
- name: ulcra
'@id': '#CcdVisit.ulcra'
datatype: double
description: ''
- name: ulcdec
'@id': '#CcdVisit.ulcdec'
datatype: double
description: ''
- name: urcra
'@id': '#CcdVisit.urcra'
datatype: double
description: ''
- name: urcdec
'@id': '#CcdVisit.urcdec'
datatype: double
description: ''
- name: lrcra
'@id': '#CcdVisit.lrcra'
datatype: double
description: ''
- name: lrcdec
'@id': '#CcdVisit.lrcdec'
datatype: double
description: ''