Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43691: Modernize GitHub actions and AASTeX template #251

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Conversation

timj
Copy link
Member

@timj timj commented Apr 4, 2024

No description provided.

@timj timj force-pushed the tickets/DM-43691 branch 2 times, most recently from a9c5f9a to 54aac51 Compare April 4, 2024 23:58
@timj timj requested a review from jonathansick April 5, 2024 00:00
AAS does not want acronyms or meta.tex so do not build them.
SPIE want DOI: https://doi.org/DOI at the end of each reference
but their style file doesn't do that.

Drops support for special ls.st handling since we no longer need that
with the new @misc entries for tech notes.
@timj timj requested a review from womullan April 9, 2024 18:23
Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions updates look fine.

Copy link
Member

@womullan womullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@@ -1,36 +1,188 @@
\documentclass[modern]{aastex62}
%% Beginning of file 'sample631.tex'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess its based on since we add some things .. does not matter really


\begin{document}
\input{authors}
\date{\today}
\title{Document Title}
\hypersetup{pdftitle={\@title}, pdfauthor={\@author}, pdfkeywords={\@keywords}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought this made the PDF better ? is it not allowed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing this didn't work with aastex though -- I got blank title and author in the PDF, indicating that the \@title variable wasn't set. I had to put my own value in. Maybe this is something that needs to be templated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now seed title with the actual title from cookie cutter.


%% Modify acknowldgments as needed.
\begin{acknowledgments}
This material is based upon work supported in part by the National Science Foundation through Cooperative Agreement AST-1258333 and Cooperative Support Agreement AST-1202910 managed by the Association of Universities for Research in Astronomy (AURA), and the Department of Energy under Contract No. DE-AC02-76SF00515 with the SLAC National Accelerator Laboratory managed by Stanford University.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@timj timj enabled auto-merge April 9, 2024 19:33
@timj timj merged commit 0424573 into main Apr 9, 2024
4 checks passed
@timj timj deleted the tickets/DM-43691 branch April 9, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants