Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report unmeasured metrics #19

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Report unmeasured metrics #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion python/lsst/verify/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
__all__ = ['Report']

from astropy.table import Table
import numpy as np

from .naming import Name

Expand Down Expand Up @@ -87,7 +88,11 @@ def make_table(self):

spec = self._spec_set[spec_name]

if spec.check(meas.quantity):
if np.isnan(meas.quantity):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure numpy.isnan is what we want here.

What sets a measurement's quantity attribute to np.nan? I know the default value is None in Measurement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking it through this seems right. 👍

# Not measured
# https://emojipedia.org/heavy-minus-sign/
statuses.append(u'\U00002796')
elif spec.check(meas.quantity):
# Passed
# http://emojipedia.org/white-heavy-check-mark/
statuses.append(u'\U00002705')
Expand Down