DM-14302: More lenient ThresholdSpecification repr test #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
May 3, 2018
Doing the string match with a floating point Quantity is fraught --- and created an issue for a numpy 1.14 upgrade. This substring matching makes sure the that ThresholdSpecification.__repr__ is generally providing the right info. Note we can't test this repr by instantiating the object from the repr string becaues the Astropy quantity __repr__ isn't instantiable.
jonathansick
force-pushed
the
tickets/DM-14302
branch
from
ca55a8d
to
0c1fcf1
Compare
|
Good idea. I added that assertion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing the string match with a floating point Quantity is fraught — and created an issue for a numpy 1.14 upgrade. This substring matching makes sure the that
ThresholdSpecification.__repr__is generally providing the right info.Note we can't test this repr by instantiating the object from the repr string because the Astropy quantity
__repr__isn't instantiable.Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/27902/pipeline