DM-20941: Cleanups (fix third-party deps in table file; remove dependency on future; update license statements) #48
Conversation
ups/verify.table
Outdated
| setupRequired(pyyaml) | ||
| setupRequired(requests) | ||
| setupRequired(numpy) | ||
| setupRequired(base) | ||
| setupRequired(utils) | ||
| setupRequired(pex_exceptions) |
There was a problem hiding this comment.
You could probably remove this dependency by noting that lsst.pex.exceptions.NotFoundError looks like a LookupError in Python land.
There was a problem hiding this comment.
Can I just switch it without introducing a breaking API change?
There was a problem hiding this comment.
There is no API change is there? I think you only use NotFoundError when you are using getPackageDir. Changing those to LookupError should be fine shouldn't it?
ups/verify.table
Outdated
| @@ -1,4 +1,8 @@ | |||
| setupRequired(sconsUtils) | |||
There was a problem hiding this comment.
We always list the sconsUtils dependency if you a package is using sconsUtils.
ups/verify.table
Outdated
| setupRequired(pyyaml) | ||
| setupRequired(requests) | ||
| setupRequired(numpy) | ||
| setupRequired(base) |
There was a problem hiding this comment.
utils is bringing in base, and your __init__.py files go out of their way to work even if base is missing, so I'd tend to not put base in here.
All of these features are now mandatory in our supported Python version.
This makes the code fully Python 3 :) Also drops the python_future dependency from the table file.
This preamble matches the standard at https://github.com/lsst/templates/tree/master/file_templates/stack_license_preamble_py
lsst.pex.exceptions.NotFoundError is equivalent to the built-in LookupError.
jonathansick
force-pushed
the
tickets/DM-20941
branch
from
41bfd5d
to
44ef913
Compare
|
Thanks @timj I've made those fixes. I'll put you down as the official reviewer in Jira too. |
__future__importsfutureandpastpackagespython_futureups/verify.buildfile that not used by anything anymore.Note I tried to remove the empty
__init__.pyfiles, but did run into test issues. I'll have to circle back on that.CI link: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/30244/pipeline