DM-22788: Use conda requests package #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be fine. Does this change need any extra testing from me? |
|
Do you think there is anything that needs to be tested other than Jenkins? |
|
It should be ok. Realistically, we'll only know for sure when the |
jonathansick
approved these changes
Jan 6, 2020
|
Is responses now part of the Conda environment for the stack? |
|
No. responses is not yet part of the stack. But it's part of my stack (possibly because I installed a bunch of boto3/moto packages to test daf_butler). |
|
Ah ok. I think this merge should be fine. If anything goes awry we'll know from the SQuaSH alerts, and even then, I can't imagine it would be difficult to resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops EUPS requests. This old requests library breaks tests when modern
responsesis installed.