DM-26671: Ignore import errors for bin.src/bin differences #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansick
approved these changes
Sep 11, 2020
brianv0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-doctestplus started throwing errors when import paths don't match correctly. There are some errors with how bin.src is handled in the unit tests in this scenario. This is the only package that experienced such errors. Adding an extra flag,
--doctest-ignore-import-errors, keeps the old behavior of pytest-doctestplusThis flag works with pytest-doctestplus 0.6.1 and future versions which are not yet in the stack.