DM-14216: Add DECam specs #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the special name 'any' for the filter of a spec that does not depend on filter. This is magic. We use tags to assign semantic context instead.
This removes the mention of the 'any' filter from the release specs.
jonathansick
approved these changes
May 3, 2018
| base: 'AD1_design.srd' | ||
| metadata_query: | ||
| instrument: 'DECAM' | ||
| filter_name: 'any' |
There was a problem hiding this comment.
I'm trying to recall if filter_name: 'any' is a thing. Do you know?
If you want a specification to not query against filter_name, you can just leave the filter_name query out.
| name: 'decam_FY17' | ||
| base: 'PF1.FY17' | ||
| metadata_query: | ||
| instrument: 'DECAM' |
There was a problem hiding this comment.
If you want to, you could create a base partial for DECAM:
id: decam
metadata_query:
instrument: 'DECAM'To allow:
name: 'decam_FY17'
base: ['PF1.FY17', '#decam']| name: 'decam_stretch' | ||
| base: 'TE2.stretch' | ||
| metadata_query: | ||
| instrument: 'DECAM' |
There was a problem hiding this comment.
Add a newline character here?
| instrument: 'HSC' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{Summary of changes. Prefix PR title with ticket handle.}
Preview the docs at: https://pipelines.lsst.io/v/DM-FIXME