DM-21320: Add first metric to colorAnalysis #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afausti
requested changes
Sep 18, 2019
metrics/pipe_analysis.yaml
Outdated
| @@ -0,0 +1,17 @@ | |||
| # Metric definitions in pipe_analysis | |||
|
|
|||
| stellar_w_principal_color_rms_width_gri: | |||
There was a problem hiding this comment.
@laurenam I would recommend not to encode information in the metric name. Metric names should be preferentially short. Especially the _gri which should be part of the metric specification instead. The same metric e.g. stellar_locus_width might have different specs if it's measured in g-r vs. r-i or if it uses other colors.
| - stellarLocus | ||
| - coadd | ||
| - PSFflux | ||
| - colorAnalysisTask |
There was a problem hiding this comment.
This looks good, keep in mind that in the future these tags might be used to filter or group metrics when you make your queries in Chronograf.
This adds the first two metrics, stellar_locus_width_wPerp and stellar_locus_width_xPerp (the blue and red arms of the r-i vs. g-r color-color planes, respectively) computed by the colorAnalysisTask in pipe_analysis.
This adds specs for the colorAnalysis metrics: stellar_locus_width_wPerp and stellar_locus_width_xPerp.
laurenam
force-pushed
the
tickets/DM-21320
branch
from
ec70d41
to
c59908d
Compare
This was referenced Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first metric, stellar_w_principal_color_rms_width_gri,
computed by the colorAnalysisTask in pipe_analysis.
{Summary of changes. Prefix PR title with ticket handle.}
Preview the docs at: https://pipelines.lsst.io/v/DM-FIXME