Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-9606: Fix Python package structure #2

Merged
merged 2 commits into from Feb 28, 2017
Merged

Conversation

jonathansick
Copy link
Member

The lsst/ base directory was missing.

The lsst/ base directory was missing.
@parejkoj
Copy link
Contributor

Do we really want any python files in here at all? This isn't a package that will be "python imported" ever.

@jonathansick
Copy link
Member Author

jonathansick commented Feb 28, 2017

Idea is that lsst.validate.metrics.__version__ might be important as it's the native way of establishing package versions in the Stack. Otherwise, there's no Python.

@parejkoj
Copy link
Contributor

Hmm... We don't have another way to track versions? It'd be a bit confusing to have a totally empty python module structure, and might tempt people to add python code to it.

@jonathansick
Copy link
Member Author

Other than interacting with git repositories on the file system or EUPS, we don't afaik.

@jonathansick
Copy link
Member Author

I could add a README in the Python path reminding contributors not to add code to validate_metrics, and look at validate_base instead.

@parejkoj
Copy link
Contributor

Yes, I think a readme would be appropriate, or a note in the base-level readme.

@jonathansick
Copy link
Member Author

Does the README addition work for your @parejkoj ?

@jonathansick jonathansick merged commit 0b2a175 into master Feb 28, 2017
@ktlim ktlim deleted the tickets/DM-9606 branch August 25, 2018 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants